Upcoming Games


Full list
Add a game

Upcoming Events

No events to display

We are not planning any more in-person events until the COVID-19 situation has improved.

ACOA right before passing the signal goes undetected

You are here: Home > Forum > General > General questions, comments, and issues > Loader V5 > ACOA right before passing the signal goes undetected

Page 2 of 2

ACOA right before passing the signal goes undetected 24/01/2021 at 18:19 #136749
GeoffM
Avatar
5500 posts
Online
bill_gensheet in post 136735 said:
Three Bridges T323 propagates, T322 is immediate on T326 and T322.
Wembley 125 and 149 propagate, 116 and 344 are immediate
Don't forget some of these signals have combined overlaps. The train can still be in the track section but past the signal.

SimSig Boss
Log in to reply
ACOA right before passing the signal goes undetected 24/01/2021 at 18:51 #136751
bill_gensheet
Avatar
661 posts
GeoffM in post 136749 said:
bill_gensheet in post 136735 said:
Three Bridges T323 propagates, T322 is immediate on T326 and T322.
Wembley 125 and 149 propagate, 116 and 344 are immediate
Don't forget some of these signals have combined overlaps. The train can still be in the track section but past the signal.
For the avoidance of doubt, these comments refer solely to checking out the propagation of aspect changes, I did not test Three Bridges or Wembley Main for not calling an ACOA.

Log in to reply
ACOA right before passing the signal goes undetected 24/01/2021 at 18:54 #136753
GeoffM
Avatar
5500 posts
Online
bill_gensheet in post 136751 said:
GeoffM in post 136749 said:
bill_gensheet in post 136735 said:
Three Bridges T323 propagates, T322 is immediate on T326 and T322.
Wembley 125 and 149 propagate, 116 and 344 are immediate
Don't forget some of these signals have combined overlaps. The train can still be in the track section but past the signal.
For the avoidance of doubt, these comments refer solely to checking out the propagation of aspect changes, I did not test Three Bridges or Wembley Main for not calling an ACOA.
Now I am very confused. You say X happens on 3B, then say you didn't actually test 3B.

???

SimSig Boss
Log in to reply
ACOA right before passing the signal goes undetected 24/01/2021 at 19:28 #136754
clive
Avatar
2279 posts
bill_gensheet in post 136706 said:
If it is as little as ~1 second, is that not near the cycle time for SimSig to recalculate things ?
[...]
Will try some experiments looking around the 20m Peter has suggested.
I don't think 20m is significant. 20m is one second at 45 mph.

The logic involved in an ACOA happening or not happening involves various different bits of code that aren't all run at the same time. So anything within one second of the train reaching the signal is not a bug, it's just a fact of life. Think of it as the driver looking at one of the instruments at just the wrong moment.

If the ACOA happens two seconds before the train reaches the signal, it should be reported. If it happens two seconds after the train reaches the signal, it should not be reported. If either of those are violated, that's a bug. Anything that happens in that 4 second window is going to be marginal and I'm not going to spend weeks trying to adjust the code to deal with it without breaking any of 50 other features.

Log in to reply
ACOA right before passing the signal goes undetected 24/01/2021 at 19:57 #136756
bill_gensheet
Avatar
661 posts
GeoffM in post 136753 said:
bill_gensheet in post 136751 said:
GeoffM in post 136749 said:
bill_gensheet in post 136735 said:
Three Bridges T323 propagates, T322 is immediate on T326 and T322.
Wembley 125 and 149 propagate, 116 and 344 are immediate
Don't forget some of these signals have combined overlaps. The train can still be in the track section but past the signal.
For the avoidance of doubt, these comments refer solely to checking out the propagation of aspect changes, I did not test Three Bridges or Wembley Main for not calling an ACOA.
Now I am very confused. You say X happens on 3B, then say you didn't actually test 3B.

???
My checks on 3B and Wembley were for the effect of E buttons on aspects, to see if that was a universal effect. It is and as you said is expected / inevitable.
Hence in my original post it is separated off under the comment "Noticed the following while doing those tests, not sure if it might be relevant." and "Similar E behaviour on other sims too:" and listed the propagation behaviours for several signals.

As long as this is not the loophole through which the ACOA gets missed then it is indeed a red herring.


As such I did my tests on trains in both directions on Motherwell (only) for the lack of ACOA calls.

Log in to reply
ACOA right before passing the signal goes undetected 24/01/2021 at 20:30 #136757
bill_gensheet
Avatar
661 posts
clive in post 136754 said:
[quote=bill_gensheet;post=136706]If it is as little as ~1 second, is that not near the
The logic involved in an ACOA happening or not happening involves various different bits of code that aren't all run at the same time. So anything within one second of the train reaching the signal is not a bug, it's just a fact of life. Think of it as the driver looking at one of the instruments at just the wrong moment.

If the ACOA happens two seconds before the train reaches the signal, it should be reported. If it happens two seconds after the train reaches the signal, it should not be reported. If either of those are violated, that's a bug. Anything that happens in that 4 second window is going to be marginal and I'm not going to spend weeks trying to adjust the code to deal with it without breaking any of 50 other features.
The initial post was that either the train should ACOA at SIG1 (say for seeing G to Y) OR at SIG2 for being R having had a G at SIG1. Either is OK, but neither still seems wrong to me.

Assume 4 aspects plain line.

I got messages of (or similar to)
"1M97: unexpected aspect 2 at SMC826 after seeing 6 at SMC822"

The above shows that the aspect change has been detected at 'SMC826', but I follow your logic and fair enough no ACOA there. However the expected aspect at SMC828 (the next signal) should then be 'no worse than YY'. SMC828 is R.

Is it the case that at SMC828 the train is still happy because it has 'remembered' SMC826 as being a Y, as the main code for that is done every second ?
Would explain why the train slows down from SMC826 not just from 'seeing' SMC828.

Log in to reply
ACOA right before passing the signal goes undetected 25/01/2021 at 08:12 #136763
clive
Avatar
2279 posts
bill_gensheet in post 136757 said:

The initial post was that either the train should ACOA at SIG1 (say for seeing G to Y) OR at SIG2 for being R having had a G at SIG1. Either is OK, but neither still seems wrong to me.
Yes, I still need to look at this.

Log in to reply